Ticket #36: patch.remote-logging.r6499.diff

src/RemoteSerializer.cc

@@ -647 +647 @@
         if ( peer->state == Peer::CLOSING )
                 return true;
 
+        Log(LogInfo, "closing connection", peer);
+        
         peer->state = Peer::CLOSING;
         return SendToChild(MSG_CLOSE, peer, 0);
         }
@@ -1416 +1418 @@
                         return true;
 
                 default:
-                        InternalCommError(fmt("unknown msg type %d",
+                        InternalCommError(fmt("unknown msg type %d in Poll()",
                                                 current_msgtype));
                         return true;
                 }
@@ -1540 +1542 @@
         default:
                 DEBUG_COMM(fmt("unexpected msg type: %d",
                                         int(current_msgtype)));
-                InternalCommError(fmt("unexpected msg type: %d",
+                InternalCommError(fmt("unexpected msg type in DoMessage(): %d",
                                         int(current_msgtype)));
                 return true; // keep going
         }
@@ -2166 +2168 @@
 
         if ( i < 0 )
                 {
+                Log(LogError, "unserialization error", current_peer);
                 CloseConnection(current_peer);
                 // Error
                 return false;

CHANGES.features

@@ -33 +33 @@
 
   Status: Ready to merge. 
 
+- Improved logging for the remote serializer. 
+
+  $Revisions: r6499
+
+  Status: Ready to merge. 
+
 ################ For local use only (not need to merge into trunk).
 
 - Including SVN revision number into version message.