Ticket #275 (new Problem)

Opened 18 months ago

broctl 'exec' crashes with dead hosts

Reported by: solomon Owned by: robin
Priority: Normal Milestone:
Component: BroControl Version: 1.5.2
Keywords: Cc:

Description

When performing the 'exec' command via broctl, if there are dead or otherwise offline hosts, broctl (python) will crash with a 'TypeError?'. Relaunching broctl and trying again sometimes works, but many times it will continue to crash if the host remains down. See below:

broctl exec killall -9 bro
Connection timed out during banner exchange
warning: connection to bro3 broke

Traceback (most recent call last):

File "/home/bro/bin/broctl", line 726, in <module>

loop.onecmd(line)

File "/usr/local/lib/python2.5/cmd.py", line 219, in onecmd

return func(arg)

File "/home/bro/bin/broctl", line 561, in do_exec

control.executeCmd(Config.nodes(), args)

File "/bro/lib/broctl/BroControl/control.py", line 1056, in executeCmd

util.output("[%s] %s\n> %s" % (node.host, (success and " " or "error"), "\n> ".join(output)))

TypeError?

Note: See TracTickets for help on using tickets.