Ticket #30 (seen Problem)
Drop logic doesn't pass reason to external script
| Reported by: | rreitz@… | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | Bro2.1 |
| Component: | Bro | Version: | branch-robin-work |
| Keywords: | Cc: |
Description
The drop.bro script calls a drop_connectivity_script external script. The only argument currently passed is the drop_address. The enclosing function do_direct_drop() has a msg parameter which has the 'reason' for the drop as the second parameter. This parameter comes from the global drop_address() function in drop.bro. I propose that this argument be passed to the external script.
I believe attached patches to notice.bro and scan.bro are required.
Attachments
Change History
Note: See
TracTickets for help on using
tickets.

Looks good to me, except that I think we should pass the msg through str_shell_escape() as it is hard to predict what kind of characters it might contain.