Bug with complex data structures

[seth]

This script:

type MetaData: record {
        a: count;
        tags: set[string];
};

global ip_data: table[addr] of set[MetaData] = table();

local m: MetaData = [$a=4, $tags=set("blah")];
if ( 1.2.3.4 !in ip_data )
        ip_data[1.2.3.4] = set(m);
else
        add ip_data[1.2.3.4][m];

Results in this error:

1306867820.149493 <no location> and ./test29.bro, line 10
   ([a=4, tags={blah}] and list of record { a:count; tags:set[string]; }): error, index type doesn't match table

[robin]

I'm actually getting a different error: 1306972010.461281 internal error: bad index type in CompositeHash::CompositeHash

[robin]

Turns out records that have more complex fields can't be used as indices for sets.

I think we could add that, but it would be a bit of work. How important is it? Can you use a table[addr] of vector, where the vector then stores the MetaData??

[seth]

I think we could add that, but it would be a bit of work. How important is
it? Can you use a table[addr] of vector, where the vector then stores the
MetaData??

Ah, I see what you are saying. Yes, I should be able to do that.

[seth]

I'm actually getting a different error: `1306972010.461281 internal error:
bad index type in CompositeHash::CompositeHash?`

Yeah, I started making some changes in CompHash?.cc and I forgot about it when I filed this ticket. The error you got is the one I meant to use for this ticket.

[seth]

This needs fixed eventually, but it's not critical at the moment. Let's push it back to a later release.

[jsiwek]

In [1e4c3d8ea293868d5c85e536201c327937c2d175/bro]:

Teach CompHash? to allow indexing by records with vector/table/set fields.

Addresses #464.

[jsiwek]

I believe the changes in topic/jsiwek/complex-record-indices fix this.

[robin]

In [27ce62077f397dfe9deecc84a04345be122c5d75/bro]:

Merge remote-tracking branch 'origin/topic/jsiwek/complex-record-indices'

• origin/topic/jsiwek/complex-record-indices: Teach CompHash? to allow indexing by records with vector/table/set fields.

Closes #464