Ticket #65 (closed Problem: fixed)
notice.bro reports run-time errors when a remote connection goes away
| Reported by: | robin | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | Bro | Version: | 1.4 |
| Keywords: | Cc: |
Description (last modified by robin) (diff)
When a Broccoli client terminates the connection, remote.bro still accesses the list of clients with the now invalid client index. We need to add check for that.
From Craig:
1234639528.393567 run-time error: peer 10001 does not exist
1234639528.393567 /usr/local/bro/share/bro/notice.bro, line 261
(n$src_peer): internal error: field value missing
Attachments
-
peer-gone-fix.diff
(442 bytes) -
added by robin 3 years ago.
Change History
comment:2 Changed 3 years ago by robin
- Status changed from seen to needs information
- Description modified (diff)
- Summary changed from Remote.bro reports run-time errors when a remote connection goes away to notice.bro reports run-time errors when a remote connection goes away
I've attached a patch, which should fix the problem. It will still return the run-time error because that's what it is. :) Note that because we can't really return a dedicated error value, we now return the local peer val also in the case that the remote peer's connection has already terminated.